Server only api #37
Closed
Server only api #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation to rpc_functions.rs. Added semi structured event call logging and track call durations.
… handling to an own module
…he pathfinder. Added a CallContext that contains the current graph for each call as well as log methods that associate the log message to the request-id and client.
Merged
chriseth
reviewed
May 25, 2023
| @@ -78,7 +78,7 @@ pub fn start_server(listen_at: &str, queue_size: usize, threads: u64) { | |||
| thread::spawn(move || loop { | |||
| let socket = rec.lock().unwrap().recv().unwrap(); | |||
| if let Err(e) = handle_connection(e.deref(), socket) { | |||
| println!("Error handling connection: {e}"); | |||
| println!("Error handling connection: {}", e); | |||
There was a problem hiding this comment.
Wait what is this? I would have expected the opposite as that is the one recommended by cargo clippy.
|
The "add capacity edges" commit looks good. Does it fix the issue? |
OP-159: fix(workflow): add feature/server_only branch trigger
…feature/add-user-balance-to-org-flow-edges
Edit computation of all edges
|
I tagged the deployed commit w v0.1.0-server+202308 and pushed it as a new branch see #55 |
|
I will close this PR as we temporarily will maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I performed some major changes to the pathfinder code: